Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve materialtextfield validation #1993

Conversation

HenrikJannsen
Copy link
Contributor

@HenrikJannsen HenrikJannsen commented Apr 4, 2024

Based on #1992

ItoroD and others added 2 commits April 4, 2024 23:58
resize of component when error is shown. Also bring back helptext when
error disappears

changed helpLabel code to errorLabel code for error validation

made helplabel invisible when error label shows

removed commented code. Setting errorlabel to help is unecessary

changed spacing of vbox to accomodate error message

removed setopacity and used setmanage instead. Made height to be calculated automatically for error text

removed unecessary commented code

enabled reformat code

added code to make height go back to original position after resize

Check that error style does not exist before you set error style
Copy link
Contributor

@axpoems axpoems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Suggestion for further improvements in #1994.

@djing-chan djing-chan merged commit 444b7d1 into bisq-network:main Apr 5, 2024
16 checks passed
@HenrikJannsen HenrikJannsen deleted the improve-materialtextfield-validation branch April 5, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants